don't play Clear signal when a new chat is created#283896
Merged
meganrogge merged 1 commit intomainfrom Dec 16, 2025
Merged
Conversation
dmitrivMS
approved these changes
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the accessibility signal accuracy by removing the Clear signal when a new chat is created. Since the chat session now continues in the background rather than being destroyed, playing the "clear" signal was misleading to users relying on accessibility features.
Key Changes
- Removed
AccessibilitySignal.clearsignal from new chat creation actions - Cleaned up unused
IAccessibilitySignalServiceimport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #281555
Because now the session continues on in the background