Fix web page loader to handle nested iframes correctly#286367
Merged
Fix web page loader to handle nested iframes correctly#286367
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the web page loader to correctly extract content from nested iframes, addressing issue #283248 where JavaDoc content embedded in iframes was not being retrieved. The fix enables the Page domain, retrieves the complete frame tree, and extracts accessibility content from all frames (main frame and all nested iframes) rather than just the main frame.
Key Changes:
- Enhanced accessibility tree extraction to iterate through all frames using Chrome DevTools Protocol's
Page.getFrameTreecommand - Refactored the accessibility domain to handle multiple root nodes (one per frame) instead of a single tree
- Added comprehensive test coverage for nested iframe scenarios
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/platform/webContentExtractor/electron-main/webPageLoader.ts |
Modified extractAccessibilityTreeContent to enable Page domain, fetch frame tree, flatten it using BFS, and extract accessibility nodes from all frames with proper cancellation token handling |
src/vs/platform/webContentExtractor/electron-main/cdpAccessibilityDomain.ts |
Refactored createNodeTree to createNodeTrees to return multiple root nodes for multi-frame scenarios, updated convertAXTreeToMarkdown to process and combine content from all trees |
src/vs/platform/webContentExtractor/test/electron-main/webPageLoader.test.ts |
Extracted common mock setup into setupDebuggerMock helper function, added comprehensive test for nested iframe content extraction, refactored all existing tests to use the new helper |
TylerLeonhardt
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #283248