mcp: fix visibility not set on cached mcp tools#286643
Merged
connor4312 merged 1 commit intomainfrom Jan 9, 2026
Merged
Conversation
TylerLeonhardt
approved these changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where cached MCP tools were missing the visibility property. When MCP tools are loaded from cache (such as from older cache entries that predate the visibility field), the visibility property may be undefined, causing issues when the tool's visibility is checked elsewhere in the codebase.
Key Changes
- Added a nullish coalescing operator (
??) to defaultvisibilitytoMcpToolVisibility.Model | McpToolVisibility.Appwhen undefined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.