Draw active indication atop the activity bar icons when shown at the bottom#286694
Merged
Draw active indication atop the activity bar icons when shown at the bottom#286694
Conversation
When the activity bar is positioned at the bottom of the sidebar, the active indicator (underline) now renders above the icons instead of below them. This provides better visual feedback for the active item. Changes: - paneCompositePart.css: Separate styling for header (top) and footer (bottom) positions, with indicator at bottom for header and top for footer - sidebarpart.css: Updated border color rules for footer position - auxiliaryBarPart.css: Updated border color rules for footer position Co-authored-by: benibenj <44439583+benibenj@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Draw active indication above activity bar icons
Draw active indication atop the activity bar icons when shown at the bottom
Jan 9, 2026
benibenj
approved these changes
Jan 19, 2026
benibenj
approved these changes
Jan 19, 2026
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the positioning of the active indicator (underline) for activity bar icons when the activity bar is positioned at the bottom. Previously, the indicator was rendering below the icons; now it correctly renders above them.
Changes:
- Split CSS rules in
paneCompositePart.cssto differentiate between.header(indicator at bottom usingborder-top) and.footer(indicator at top usingtop: 2px+border-bottom) - Added footer-specific border color rules in
sidebarpart.cssandauxiliaryBarPart.cssto apply the correct active border color when the activity bar is in footer position
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/browser/parts/media/paneCompositePart.css | Split .header-or-footer rules into .header and .footer variants with appropriate positioning (bottom/top) and border direction (border-top/border-bottom) for all states (checked, focus, clicked) |
| src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css | Added .footer specific rules to use border-bottom-color instead of border-top-color for the active indicator |
| src/vs/workbench/browser/parts/auxiliarybar/media/auxiliaryBarPart.css | Added .footer specific rules to use border-bottom-color instead of border-top-color for the active indicator |
dmitrivMS
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When activity bar position is set to "bottom", the active indicator was rendering below the icons. It should render above them instead.
Changes
.header-or-footerrules into.header-or-footer.header(indicator at bottom) and.header-or-footer.footer(indicator at top usingtop: 2px+border-bottom)border-bottom-colorrule for footer positionborder-bottom-colorrule for footer positionBefore (indicator below icons)
After
Indicator renders above icons when activity bar is at bottom position.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.