Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the test/leaks/ directory containing an obsolete memory leak testing infrastructure that depended on AMD module loading. The removal aligns with VS Code's broader effort to migrate away from AMD (as referenced in issue #285255).
Key Changes
- Removed AMD-based memory leak test infrastructure from
test/leaks/
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/leaks/server.js | Removed Koa-based development server that served the leak test HTML page |
| test/leaks/package.json | Removed package dependencies for the Koa server (koa, koa-mount, koa-static) |
| test/leaks/index.html | Removed HTML test page that used AMD's require.config and vs/loader.js to test for memory leaks in event handlers |
jrieken
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FYI @joaomoreno
See #285255