Skip to content

Don't show suggest hint when it's not enabled#286744

Merged
Tyriar merged 1 commit intomainfrom
tyriar/286680
Jan 9, 2026
Merged

Don't show suggest hint when it's not enabled#286744
Tyriar merged 1 commit intomainfrom
tyriar/286680

Conversation

@Tyriar
Copy link
Copy Markdown
Contributor

@Tyriar Tyriar commented Jan 9, 2026

Fixes #286680

image

@Tyriar Tyriar added this to the January 2026 milestone Jan 9, 2026
@Tyriar Tyriar self-assigned this Jan 9, 2026
Copilot AI review requested due to automatic review settings January 9, 2026 14:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses issue #286680 by preventing the terminal suggest hint from being displayed when the terminal suggest feature is disabled. The change adds a configuration check before attempting to look up the keybinding for the suggest command.

Key changes:

  • Added a configuration check to verify if terminal suggest is enabled before showing the suggest hint
  • Made the keybinding lookup conditional based on the enabled setting

@Tyriar Tyriar marked this pull request as ready for review January 9, 2026 14:37
@Tyriar Tyriar enabled auto-merge January 9, 2026 14:37
@Tyriar Tyriar merged commit a41570f into main Jan 9, 2026
27 of 28 checks passed
@Tyriar Tyriar deleted the tyriar/286680 branch January 9, 2026 14:40
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal hint shows up about terminal suggestions even when suggesting is disabled.

3 participants