Merged
Conversation
Tyriar
approved these changes
Jan 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky accessibility smoke test by correcting the exclude rule patterns for aria-allowed-attr violations. The patterns were incorrectly formatted as CSS selectors (with leading dots) when they should have been plain strings to match against HTML content.
- Removes leading dots from
aria-allowed-attrexclude patterns ('.monaco-list'→'monaco-list','.monaco-list-row'→'monaco-list-row') - Adds a clarifying comment explaining that patterns match against HTML strings, not CSS selectors
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #286804