Fix Inefficient results collection in TextSearchResultsCollector#286904
Merged
osortega merged 1 commit intomicrosoft:mainfrom Jan 12, 2026
Merged
Fix Inefficient results collection in TextSearchResultsCollector#286904osortega merged 1 commit intomicrosoft:mainfrom
Inefficient results collection in TextSearchResultsCollector#286904osortega merged 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in TextSearchResultsCollector where the _currentUri field was never being assigned, causing results from the same file to be incorrectly split into multiple ISerializedFileMatch objects instead of being grouped together.
Changes:
- Added missing assignment
this._currentUri = data.uri;inTextSearchResultsCollector.add()when creating a new file match - Updated the integration test "Search with context matches" to expect the correct behavior: 1 file match containing 3 results instead of 3 separate file matches
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/services/search/common/textSearchManager.ts | Added missing this._currentUri assignment to properly track the current file being processed |
| src/vs/workbench/services/search/test/node/textSearch.integrationTest.ts | Updated test expectations to reflect correct behavior where results from the same file are grouped into a single file match |
osortega
approved these changes
Jan 12, 2026
Tyriar
approved these changes
Jan 12, 2026
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
…llector Fix `Inefficient results collection in TextSearchResultsCollector`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes inefficient results collection in TextSearchResultsCollector where
_currentUriwas never being set, causing results from the same file to be incorrectly split into separateISerializedFileMatchobjects.Changes
this._currentUri = data.uri;assignment inTextSearchResultsCollector.add()'Search with context matches'to expect the correct behaviorFixes Inefficient results collection in TextSearchResultsCollector #264127