Add delete icon to Hidden Terminals menu item#287133
Merged
meganrogge merged 5 commits intomainfrom Jan 12, 2026
Merged
Conversation
- Added trash icon button to TerminalTabsChatEntry that deletes all hidden terminals - Added CSS styling for the delete button with hover effects - Injected ITerminalService to enable disposing of terminals - Added keyboard navigation support for the delete button - Prevented entry click handler from firing when clicking delete button Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Co-authored-by: meganrogge <29464607+meganrogge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add a delete icon to Hidden Terminals menu item
Add delete icon to Hidden Terminals menu item
Jan 12, 2026
Collaborator
|
@Tyriar I changed it so it only shows on hover or keyboard focus. WDYT? delete.mov |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a delete button to the Hidden Terminals menu item in the terminal tabs view, allowing users to delete all hidden chat terminals at once instead of opening and deleting them individually.
Changes:
- Added a trash icon button to
TerminalTabsChatEntrythat deletes all hidden chat terminals in parallel - Implemented click and keyboard handlers with proper event propagation control
- Styled the delete button with hover effects and visibility rules in CSS
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/terminal/browser/terminalTabsChatEntry.ts |
Added delete button DOM element, event handlers for click and keyboard interactions, and _deleteAllHiddenTerminals method with proper ARIA labels |
src/vs/workbench/contrib/terminal/browser/media/terminal.css |
Added styling for delete button with hover states, display rules for when tabs have text, and visibility control |
Tyriar
previously requested changes
Jan 12, 2026
|
|
||
| .monaco-workbench .pane-body.integrated-terminal .terminal-tabs-chat-entry:hover .terminal-tabs-chat-entry-delete, | ||
| .monaco-workbench .pane-body.integrated-terminal .terminal-tabs-chat-entry:focus-within .terminal-tabs-chat-entry-delete { | ||
| display: flex; |
Contributor
Tyriar
approved these changes
Jan 12, 2026
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Adds a trash icon to the Hidden Terminals menu item that deletes all hidden chat terminals at once. Previously, users had to open each hidden terminal individually and delete them one by one.
Changes
Added delete button to
TerminalTabsChatEntryCodicon.trashcan) positioned after the labelITerminalService.safeDisposeTerminal()for each hidden terminal in parallelStyled delete button in
terminal.cssUI
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Fixes #275235