Skip to content

chore: bump native node modules#287597

Merged
rzhao271 merged 2 commits intomainfrom
rzhao271/bump-packages-2
Jan 13, 2026
Merged

chore: bump native node modules#287597
rzhao271 merged 2 commits intomainfrom
rzhao271/bump-packages-2

Conversation

@rzhao271
Copy link
Copy Markdown
Collaborator

@rzhao271 rzhao271 commented Jan 13, 2026

This PR bumps several native node modules to bring in the latest BinSkim fixes.

The previous attempt brought in packages compiled with a fortify-source flag that were incompatible with the Linux build.

Verification build: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=391398&view=results

Copilot AI review requested due to automatic review settings January 13, 2026 18:16
@rzhao271 rzhao271 self-assigned this Jan 13, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 13, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps several native node modules to bring in the latest BinSkim fixes, addressing compatibility issues from a previous attempt that used packages compiled with incompatible fortify-source flags for Linux builds.

Changes:

  • Updated native node module versions for @vscode/spdlog, @vscode/windows-process-tree, @vscode/windows-registry, @vscode/policy-watcher, @vscode/windows-mutex, @vscode/sqlite3, and native-keymap
  • Updated distro hash reference in package.json
  • Modified both main package-lock.json and remote/package-lock.json to reflect the version bumps

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

File Description
package.json Updated @vscode/sqlite3 to 5.1.11-vscode and distro hash
package-lock.json Updated locked versions for @vscode/policy-watcher, @vscode/spdlog, @vscode/sqlite3, @vscode/windows-mutex, @vscode/windows-registry, and native-keymap to their latest minor/patch versions
remote/package-lock.json Updated locked versions for @vscode/spdlog, @vscode/windows-process-tree, and @vscode/windows-registry
Files not reviewed (1)
  • remote/package-lock.json: Language not supported
Comments suppressed due to low confidence (5)

package.json:82

  • The package.json specifies @vscode/policy-watcher: "^1.3.2" but package-lock.json has locked it to 1.3.7. Consider updating the minimum version constraint in package.json to "^1.3.7" to accurately reflect the tested version and ensure consistency across environments.
    "@vscode/policy-watcher": "^1.3.2",

package.json:90

  • The package.json specifies @vscode/windows-mutex: "^0.5.0" but package-lock.json has locked it to 0.5.3. Consider updating the minimum version constraint in package.json to "^0.5.3" to accurately reflect the tested version and ensure consistency across environments.
    "@vscode/windows-mutex": "^0.5.0",

package.json:91

  • The package.json specifies @vscode/windows-process-tree: "^0.6.0" but package-lock.json has locked it to 0.6.3. Consider updating the minimum version constraint in package.json to "^0.6.3" to accurately reflect the tested version and ensure consistency across environments.
    "@vscode/windows-process-tree": "^0.6.0",

package.json:92

  • The package.json specifies @vscode/windows-registry: "^1.1.0" but package-lock.json has locked it to 1.1.3. Consider updating the minimum version constraint in package.json to "^1.1.3" to accurately reflect the tested version and ensure consistency across environments.
    "@vscode/windows-registry": "^1.1.0",

package.json:110

  • The package.json specifies native-keymap: "^3.3.5" but package-lock.json has locked it to 3.3.9. Consider updating the minimum version constraint in package.json to "^3.3.9" to accurately reflect the tested version and ensure consistency across environments.
    "native-keymap": "^3.3.5",

Comment thread package.json
meganrogge
meganrogge previously approved these changes Jan 13, 2026
@meganrogge
Copy link
Copy Markdown
Collaborator

@rzhao271 CI failing

meganrogge
meganrogge previously approved these changes Jan 13, 2026
@rzhao271
Copy link
Copy Markdown
Collaborator Author

@rzhao271 rzhao271 merged commit 88eb80e into main Jan 13, 2026
35 checks passed
@rzhao271 rzhao271 deleted the rzhao271/bump-packages-2 branch January 13, 2026 20:42
eli-w-king pushed a commit that referenced this pull request Jan 14, 2026
* chore: bump native node modules

* chore: update Debian deps list
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants