Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps several native node modules to bring in the latest BinSkim fixes, addressing compatibility issues from a previous attempt that used packages compiled with incompatible fortify-source flags for Linux builds.
Changes:
- Updated native node module versions for @vscode/spdlog, @vscode/windows-process-tree, @vscode/windows-registry, @vscode/policy-watcher, @vscode/windows-mutex, @vscode/sqlite3, and native-keymap
- Updated distro hash reference in package.json
- Modified both main package-lock.json and remote/package-lock.json to reflect the version bumps
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated @vscode/sqlite3 to 5.1.11-vscode and distro hash |
| package-lock.json | Updated locked versions for @vscode/policy-watcher, @vscode/spdlog, @vscode/sqlite3, @vscode/windows-mutex, @vscode/windows-registry, and native-keymap to their latest minor/patch versions |
| remote/package-lock.json | Updated locked versions for @vscode/spdlog, @vscode/windows-process-tree, and @vscode/windows-registry |
Files not reviewed (1)
- remote/package-lock.json: Language not supported
Comments suppressed due to low confidence (5)
package.json:82
- The package.json specifies @vscode/policy-watcher: "^1.3.2" but package-lock.json has locked it to 1.3.7. Consider updating the minimum version constraint in package.json to "^1.3.7" to accurately reflect the tested version and ensure consistency across environments.
"@vscode/policy-watcher": "^1.3.2",
package.json:90
- The package.json specifies @vscode/windows-mutex: "^0.5.0" but package-lock.json has locked it to 0.5.3. Consider updating the minimum version constraint in package.json to "^0.5.3" to accurately reflect the tested version and ensure consistency across environments.
"@vscode/windows-mutex": "^0.5.0",
package.json:91
- The package.json specifies @vscode/windows-process-tree: "^0.6.0" but package-lock.json has locked it to 0.6.3. Consider updating the minimum version constraint in package.json to "^0.6.3" to accurately reflect the tested version and ensure consistency across environments.
"@vscode/windows-process-tree": "^0.6.0",
package.json:92
- The package.json specifies @vscode/windows-registry: "^1.1.0" but package-lock.json has locked it to 1.1.3. Consider updating the minimum version constraint in package.json to "^1.1.3" to accurately reflect the tested version and ensure consistency across environments.
"@vscode/windows-registry": "^1.1.0",
package.json:110
- The package.json specifies native-keymap: "^3.3.5" but package-lock.json has locked it to 3.3.9. Consider updating the minimum version constraint in package.json to "^3.3.9" to accurately reflect the tested version and ensure consistency across environments.
"native-keymap": "^3.3.5",
meganrogge
previously approved these changes
Jan 13, 2026
Collaborator
|
@rzhao271 CI failing |
a54869c to
aaab627
Compare
meganrogge
previously approved these changes
Jan 13, 2026
Collaborator
Author
|
New verification build: https://dev.azure.com/monacotools/Monaco/_build/results?buildId=391415&view=results |
aeschli
approved these changes
Jan 13, 2026
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
* chore: bump native node modules * chore: update Debian deps list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps several native node modules to bring in the latest BinSkim fixes.
The previous attempt brought in packages compiled with a fortify-source flag that were incompatible with the Linux build.
Verification build: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=391398&view=results