escape backticks so they're rendered correctly #287606
Merged
meganrogge merged 1 commit intomainfrom Jan 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where backticks in localized messages were not being rendered correctly in Markdown by escaping them with backslashes. The fix ensures that task names and other placeholders wrapped in backticks are displayed as literal backticks in chat messages rather than being interpreted as markdown code delimiters.
Changes:
- Escaped backticks in all localized strings used within MarkdownString constructors across three task tool files
- Changed all instances of
`{0}`to\`{0}\`in localize() calls for proper markdown rendering
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/runTaskTool.ts | Escaped backticks in 11 localized message strings (task not found, task running, terminal messages, and confirmation dialogs) |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/getTaskOutputTool.ts | Escaped backticks in 6 localized message strings (task not found, task running, checking/checked output, terminal not found) |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/task/createAndRunTaskTool.ts | Escaped backticks in 2 localized message strings (task already exists messages) |
rzhao271
approved these changes
Jan 13, 2026
roblourens
reviewed
Jan 13, 2026
| return { | ||
| invocationMessage: new MarkdownString(localize('taskExists', 'Task `{0}` already exists.', task.label)), | ||
| pastTenseMessage: new MarkdownString(localize('taskExistsPast', 'Task `{0}` already exists.', task.label)), | ||
| invocationMessage: new MarkdownString(localize('taskExists', 'Task \`{0}\` already exists.', task.label)), |
Collaborator
Author
There was a problem hiding this comment.
Yeah this didn't fix it, for some reason just didn't hit it when I tested this in oss.... 🤔
Seeing this in insider's
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #287593