Skip to content

Making chat session repo quick pick searchable#287608

Merged
osortega merged 2 commits intomainfrom
osortega/ytterbic-stingray
Jan 13, 2026
Merged

Making chat session repo quick pick searchable#287608
osortega merged 2 commits intomainfrom
osortega/ytterbic-stingray

Conversation

@osortega
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 13, 2026 18:53
@osortega osortega self-assigned this Jan 13, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

vs-code-engineering bot commented Jan 13, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/chatSessions/searchableOptionPickerActionItemtest.ts

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request makes the chat session repository picker searchable by adding a query parameter to the search callback and implementing debounced search functionality in the QuickPick UI.

Changes:

  • Modified the onSearch callback signature to accept a query parameter for filtering search results
  • Implemented debounced search with cancellation support in the searchable QuickPick
  • Updated the API contract across the extension host and main thread communication layers

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/vscode-dts/vscode.proposed.chatSessionsProvider.d.ts Updated API definition to add query parameter to onSearch callback
src/vs/workbench/contrib/chat/common/chatSessionsService.ts Updated service interface signature for onSearch
src/vs/workbench/contrib/chat/browser/chatSessions/searchableOptionPickerActionItemtest.ts Implemented debounced search with cancellation tokens and proper cleanup
src/vs/workbench/api/common/extHostChatSessions.ts Updated to pass query parameter to extension's onSearch callback
src/vs/workbench/api/common/extHost.protocol.ts Updated protocol interface to include query parameter
src/vs/workbench/api/browser/mainThreadChatSessions.ts Updated proxy call to pass query parameter

@osortega osortega marked this pull request as draft January 13, 2026 19:25
@osortega osortega marked this pull request as ready for review January 13, 2026 19:39
@osortega osortega merged commit f716e90 into main Jan 13, 2026
22 checks passed
@osortega osortega deleted the osortega/ytterbic-stingray branch January 13, 2026 21:12
eli-w-king pushed a commit that referenced this pull request Jan 14, 2026
Making chat session repo quick pick searchable
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Feb 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants