Integrated Browser: Fix buggy Right Click -> Copy into New Window

[jruales]

Fixes #284525
(Copy into New Window was very buggy. Not to be confused with Move into New Window, which has been working fine.)

This PR does the following:

• Creates an independent browser editor to avoid linked state
• Adds a resize observer to fix some issues where sometimes the copied window ended up with a zero-size webview or where a moved window ended up with a squashed webview until the user resized the window

---

Related feature: #286579

[Copilot]

Pull request overview

This pull request adds support for copying integrated browser editors into new windows. The main change is implementing the copy() method in BrowserEditorInput to create independent browser view instances with new unique IDs. Additionally, the PR refactors the view initialization logic in BrowserEditor to use a ResizeObserver for handling window layout changes, replacing the previous scheduleAtNextAnimationFrame approach.

Changes:

• Implemented copy() method in BrowserEditorInput to create new browser instances with unique IDs when copying to new windows
• Replaced animation frame scheduling with ResizeObserver for more reliable layout handling during window moves/resizes
• Added layoutAsync() helper method to ensure proper view attachment before operations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/vs/workbench/contrib/browserView/electron-browser/browserEditorInput.ts	Added copy() method to create independent browser editor instances with new UUIDs and injected IInstantiationService
src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts	Refactored initialization to use ResizeObserver for layout handling and added layoutAsync() method; removed unused scheduleAtNextAnimationFrame import

Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/browserView/electron-browser/browserEditor.ts:725

• The layout() and layoutAsync() methods contain duplicated logic for calculating and passing layout parameters. Consider refactoring to extract the common layout logic into a shared helper method that both methods can call, with only the async/await handling differing between them.

	override layout(): void {
		void this.layoutAsync();
	}

	/**
	 * Async version of layout that waits for the layout to complete.
	 */
	private async layoutAsync(): Promise<void> {
		if (this._model) {
			this.checkOverlays();

			const containerRect = this._browserContainer.getBoundingClientRect();
			await this._model.layout({
				windowId: this.group.windowId,
				x: containerRect.left,
				y: containerRect.top,
				width: containerRect.width,
				height: containerRect.height,
				zoomFactor: getZoomFactor(this.window)
			});
		}
	}

	override clearInput(): void {
		this._inputDisposables.clear();

		// Cancel any active element selection
		if (this._elementSelectionCts) {
			this._elementSelectionCts.dispose(true);
			this._elementSelectionCts = undefined;
		}

		void this._model?.setVisible(false);
		this._model = undefined;

		this._canGoBackContext.reset();

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.