Skip to content

enable lm management editor for business and enterprise#288966

Merged
sandy081 merged 2 commits intomainfrom
sandy081/parliamentary-condor
Jan 19, 2026
Merged

enable lm management editor for business and enterprise#288966
sandy081 merged 2 commits intomainfrom
sandy081/parliamentary-condor

Conversation

@sandy081
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings January 19, 2026 19:02
@sandy081 sandy081 enabled auto-merge (squash) January 19, 2026 19:02
@sandy081 sandy081 self-assigned this Jan 19, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 19, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to enable the language models management editor for Business and Enterprise tier users by updating preconditions and add button logic.

Changes:

  • Added Business and Enterprise plan context keys to the "Manage Language Models" command preconditions
  • Modified the add button enablement logic in the models widget to explicitly exclude Business and Enterprise users from adding models

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/vs/workbench/contrib/chat/browser/chatManagement/chatManagement.contribution.ts Adds planBusiness and planEnterprise to the precondition for the "Manage Language Models" command, allowing Business and Enterprise users to open the management editor
src/vs/workbench/contrib/chat/browser/chatManagement/chatModelsWidget.ts Refactors add button logic and explicitly excludes Business and Enterprise users from adding models by updating the supportsAddingModels condition

Comment on lines +1176 to +1178
&& entitlement !== ChatEntitlement.Available
&& entitlement !== ChatEntitlement.Business
&& entitlement !== ChatEntitlement.Enterprise);
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title states "enable lm management editor for business and enterprise", but this code explicitly disables the ability for Business and Enterprise users to add models. The old code allowed any user with a plan (including Business and Enterprise) to add models via hasPlan, but now Business and Enterprise are explicitly excluded from supportsAddingModels.

If this is intentional (e.g., Business/Enterprise users can view but not add models), the PR title should be clarified to reflect this nuanced behavior. If it's not intentional, the logic should be corrected to allow Business and Enterprise users to add models.

Suggested change
&& entitlement !== ChatEntitlement.Available
&& entitlement !== ChatEntitlement.Business
&& entitlement !== ChatEntitlement.Enterprise);
&& entitlement !== ChatEntitlement.Available);

Copilot uses AI. Check for mistakes.
@sandy081 sandy081 merged commit a320e12 into main Jan 19, 2026
22 checks passed
@sandy081 sandy081 deleted the sandy081/parliamentary-condor branch January 19, 2026 19:23
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants