Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused experimental setting chat.experimentalShowAllModels and its associated code. The setting was previously used to override the isUserSelectable property of language models but is no longer needed.
Changes:
- Removed the experimental configuration service dependency from
LanguageModelsService - Removed the experimental setting check in
lookupLanguageModel()method that overrode model selectability - Updated test files to remove the now-unnecessary
TestConfigurationServicedependency
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/languageModels.ts |
Removed IConfigurationService import, _configurationService constructor parameter, and experimental setting check in lookupLanguageModel method |
src/vs/workbench/contrib/chat/test/common/languageModels.test.ts |
Removed TestConfigurationService import and removed its usage from test suite instantiations to match updated constructor signature |
lramos15
previously approved these changes
Jan 20, 2026
Tyriar
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lramos15 - I do not see this setting enabled for experiement and therefore it seems unused code. Hence removing it.