refactor: update chat session handling to use sessionResource instead of sessionId#289178
Merged
refactor: update chat session handling to use sessionResource instead of sessionId#289178
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the ManageTodoListTool implementation from using string-based session IDs to URI-based session resources, as part of the larger effort tracked in issue #274403 to support contributed chat providers.
Changes:
- Updated
IChatTodoListContentinterface to usesessionResource: URIinstead ofsessionId: string - Refactored
ManageTodoListToolto obtain session resource from invocation context and handle missing context gracefully - Removed deprecated session ID parameters from tool input schema and telemetry
- Updated test cases to use the new
sessionResourcefield
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/chat/common/chatService/chatService.ts |
Updated IChatTodoListContent interface to replace sessionId string with sessionResource URI |
src/vs/workbench/contrib/chat/common/tools/builtinTools/manageTodoListTool.ts |
Refactored to use sessionResource from invocation context, removed fallback to default session ID, cleaned up unused imports and telemetry fields |
src/vs/workbench/contrib/chat/test/browser/accessibility/chatResponseAccessibleView.test.ts |
Updated test data to use sessionResource URI instead of sessionId string |
bpasero
previously approved these changes
Jan 20, 2026
mjbvz
previously approved these changes
Jan 20, 2026
Member
|
@bhavyaus Red CI |
lramos15
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: #274403