Skip to content

action list hover follow ups#289185

Merged
meganrogge merged 3 commits intomainfrom
merogge/action-list-follow
Jan 20, 2026
Merged

action list hover follow ups#289185
meganrogge merged 3 commits intomainfrom
merogge/action-list-follow

Conversation

@meganrogge
Copy link
Copy Markdown
Collaborator

No description provided.

@lramos15
Copy link
Copy Markdown
Member

Since we're no longer doing show more can we remove the new command that was added with query param?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies hover functionality in the action list by removing unused hover actions support and streamlining hover content generation in the model picker.

Changes:

  • Removed support for IHoverAction in action list hover configuration
  • Simplified model picker hover content to use only tooltip metadata instead of combining tooltip and detail information
  • Cleaned up conditional checks for hover actions throughout the action list implementation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/vs/workbench/contrib/chat/browser/widget/input/modelPickerActionItem.ts Simplified hover content generation to use only model.metadata.tooltip, removing redundant combination with model.metadata.detail which is already displayed in the description field
src/vs/platform/actionWidget/browser/actionList.ts Removed unused IHoverAction import, removed actions field from IActionListItemHover interface, and cleaned up all references to hover actions in the implementation

@meganrogge meganrogge merged commit 73f17ed into main Jan 20, 2026
22 checks passed
@meganrogge meganrogge deleted the merogge/action-list-follow branch January 20, 2026 20:21
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants