Fixes https://github.com/microsoft/vscode/issues/277133#289198
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a disposal pattern issue (issue #277133) where telemetry reporters weren't being properly disposed, potentially causing memory leaks. The fix refactors the disposal lifecycle by using the correct disposal API and simplifying the callback pattern.
Changes:
- Changed from
deleteAndLeak()todelete()to ensure proper disposal of telemetry reporters - Simplified the reporter's disposal callback from wrapping in
toDisposable()to directly calling the provided callback - Removed unnecessary
toDisposableimport
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/editTelemetry/browser/telemetry/arcTelemetrySender.ts |
Updated disposal calls from deleteAndLeak() to delete() to properly dispose of ArcTelemetryReporter instances in two sender classes |
src/vs/workbench/contrib/editTelemetry/browser/telemetry/arcTelemetryReporter.ts |
Simplified disposal pattern by renaming callback parameter and removing redundant toDisposable wrapper, directly invoking the disposal callback instead |
dmitrivMS
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.