chat: remove fragile timeout in revealSessionIfAlreadyOpen#289232
Merged
connor4312 merged 1 commit intomainfrom Jan 20, 2026
Merged
chat: remove fragile timeout in revealSessionIfAlreadyOpen#289232connor4312 merged 1 commit intomainfrom
connor4312 merged 1 commit intomainfrom
Conversation
Removes the 500ms timeout fallback that was a hack to wait for focus transfer to auxiliary windows. Instead, only waits for focus transfer when preserveFocus is false, since preserveFocus: true means the window won't get focus and the layout service won't fire onDidChangeActiveContainer. - Remove unused raceCancellablePromises import - Add preserveFocus check to avoid waiting when focus won't transfer - Remove timeout(500) that could cause UI to appear in wrong location Fixes #279738 (Commit message generated by Copilot)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a fragile 500ms timeout fallback in the chat widget service that was used to wait for focus transfer to auxiliary windows. The fix adds a preserveFocus check to avoid waiting for focus transfer when it won't occur.
Changes:
- Removes unused
raceCancellablePromisesimport - Adds
preserveFocuscheck to the condition that determines when to wait for focus transfer - Removes the
timeout(500)race condition that could cause UI to appear in the wrong location
Tyriar
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the 500ms timeout fallback that was a hack to wait for focus
transfer to auxiliary windows. Instead, only waits for focus transfer when
preserveFocus is false, since preserveFocus: true means the window won't
get focus and the layout service won't fire onDidChangeActiveContainer.
Fixes #279738
(Commit message generated by Copilot)