Skip to content

Adopt hover for session type picker and mode picker#289242

Merged
benibenj merged 1 commit intomainfrom
benibenj/radical-wolf
Jan 20, 2026
Merged

Adopt hover for session type picker and mode picker#289242
benibenj merged 1 commit intomainfrom
benibenj/radical-wolf

Conversation

@benibenj
Copy link
Copy Markdown
Contributor

Copilot Generated Description: Implement hover functionality for the session type picker and mode picker, providing additional context through hover descriptions. Update related components to utilize the new hover feature. Adjust tooltip handling to accommodate the changes.

closes #289041

Copilot AI review requested due to automatic review settings January 20, 2026 22:58
@benibenj benibenj enabled auto-merge January 20, 2026 22:58
@benibenj benibenj self-assigned this Jan 20, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/agentSessions/agentSessions.ts

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request implements hover functionality for chat input pickers, replacing traditional tooltips with rich hover descriptions. The changes improve user experience by providing more detailed contextual information when users interact with session type and mode pickers.

Changes:

  • Adopted hover service for actionList items, replacing instant hover with delayed hover for better UX
  • Added getAgentSessionProviderDescription helper function to centralize session provider descriptions
  • Updated session type picker and mode picker to use hover instead of tooltip properties
  • Improved hover lifecycle management in ActionList using MutableDisposable

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sessionTargetPickerActionItem.ts Updated to use hoverDescription property and pass hover content via hover object instead of tooltip
modePickerActionItem.ts Changed from tooltip to hover for mode picker actions to provide richer contextual information
delegationSessionPickerActionItem.ts Set tooltip to empty string for "New Chat Session" action (incomplete - missing hover property)
agentSessions.ts Added getAgentSessionProviderDescription function to provide localized hover descriptions for all session providers
actionList.ts Improved hover management by using MutableDisposable and switched from instant to delayed hover for better UX

@benibenj benibenj merged commit 41c7fd6 into main Jan 20, 2026
27 of 28 checks passed
@benibenj benibenj deleted the benibenj/radical-wolf branch January 20, 2026 23:41
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve descriptions of agents

3 participants