preserve agent session user filter when clicking notification filter#289506
Merged
joshspicer merged 2 commits intomainfrom Jan 21, 2026
Merged
preserve agent session user filter when clicking notification filter#289506joshspicer merged 2 commits intomainfrom
joshspicer merged 2 commits intomainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
mjbvz
previously approved these changes
Jan 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request attempts to preserve the user's filter state when toggling notification filters (unread/in-progress badges) in the agent sessions view. Before this change, clicking a notification filter would simply clear any existing filter. With this change, the code tries to save the user's filter before applying a badge filter and restore it later.
Changes:
- Added storage key
PREVIOUS_FILTER_STORAGE_KEYto save user's filter before applying badge filters - Implemented
_saveUserFilter()method to save current filter to storage - Implemented
_restoreUserFilter()method to restore previously saved filter - Updated
_openSessionsWithFilter()to save/restore filters when toggling badge filters instead of clearing - Updated
_clearFilterIfCategoryEmpty()to restore user's filter instead of clearing when a filtered category becomes empty
osortega
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.