feat: add allowlist compatibility check for API proposals in extensions

[joaomoreno]

No description provided.

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

• build/azure-pipelines/common/releaseBuild.ts
• build/azure-pipelines/common/versionCompatibility.ts

[Copilot]

Pull request overview

This PR adds a new validation step to check that API proposals declared in an extension's package.json are properly allowlisted in VS Code's product.json. This ensures consistency between what extensions use and what VS Code explicitly allows.

Changes:

• Added areAllowlistedApiProposalsMatching function to validate API proposal allowlist consistency
• Integrated the new validation into the Copilot Chat compatibility check in release builds
• Added comprehensive test coverage for the new validation logic

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
build/azure-pipelines/common/versionCompatibility.ts	Added new areAllowlistedApiProposalsMatching function with logic to validate that all API proposals declared in an extension's package.json are allowlisted in product.json, handling versioned proposals by stripping version suffixes. Includes comprehensive unit tests covering various scenarios.
build/azure-pipelines/common/releaseBuild.ts	Integrated the new allowlist validation into the Copilot Chat compatibility check, loading product.json and calling the validation function with appropriate error handling and console output.

Comments suppressed due to low confidence (2)

build/azure-pipelines/common/versionCompatibility.ts:431

• Trailing whitespace found at the end of the line. This should be removed to maintain code cleanliness.
  build/azure-pipelines/common/versionCompatibility.ts:164
• The error message is inconsistent with VS Code's capitalization conventions. In the codebase, "product.json" is typically capitalized as "Product.json" when referring to it in user-facing messages (see line 89 in releaseBuild.ts and line 121 in the same file). For consistency with the user-facing message on line 121 of releaseBuild.ts, consider using "Product.json" instead of "product.json".

			errors.push(`API proposal '${proposal}' is declared in extension '${extensionId}' package.json but is not allowlisted in product.json`);

[Copilot]

Trailing whitespace found at the end of the line. This should be removed to maintain code cleanliness.

This issue also appears in the following locations of the same file:

• line 431

Suggested change

	// Versioned proposal not in allowlist - incompatible
	assert.strictEqual(areAllowlistedApiProposalsMatching('test.ext', ['proposalA'], ['proposalB@2']).compatible, false);
	// Versioned proposal not in allowlist - incompatible
	assert.strictEqual(areAllowlistedApiProposalsMatching('test.ext', ['proposalA'], ['proposalB@2']).compatible, false);

[Copilot]

The error message is inconsistent with VS Code's capitalization conventions. In the codebase, "product.json" is typically capitalized as "Product.json" when referring to it in user-facing messages (see line 89 in releaseBuild.ts and line 121 in the same file). However, when used in technical contexts or inline in sentences, it's kept lowercase. For consistency with the user-facing message on line 121 of releaseBuild.ts, consider using "Product.json" at the start of error messages.

This issue also appears in the following locations of the same file:

• line 164