Fix webview tool output disappearing#290055
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Jan 24, 2026
Merged
Conversation
dmitrivMS
approved these changes
Jan 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Addresses a chat UI regression where tool output rendered via webviews can disappear after the element is detached/hidden and later shown again.
Changes:
- Reinitialize tool output webviews when the chat content part becomes visible again.
- Reinitialize tool output webviews when the content part is remounted after virtualization.
- Pass a remount event from
ChatToolInvocationPartdown toChatToolOutputSubPart.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolOutputPart.ts | Hooks tool output webview reinitialization to visibility changes and remount events so output doesn’t disappear after detach/hide. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/toolInvocationParts/chatToolInvocationPart.ts | Adds and wires an onDidRemount event into ChatToolOutputSubPart construction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289237