Close welcome view when clicking on View all sessions#290069
Merged
Conversation
roblourens
approved these changes
Jan 24, 2026
roblourens
reviewed
Jan 24, 2026
| } | ||
|
|
||
| private revealMaximizedChat(): void { | ||
| this.commandService.executeCommand('workbench.action.closeActiveEditor'); |
Member
There was a problem hiding this comment.
Shouldn't we be awaiting these to ensure they don't step on each others' feet? Also try to use proper services rather than executeCommand, since it's untyped, relies on a magic string, no "find all references" etc.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the agent sessions welcome experience so the welcome editor closes when navigating to the full chat/sessions experience.
Changes:
- Close the active editor before opening the Chat view from the welcome page.
- Keep existing behavior that opens Chat and maximizes the auxiliary bar when needed.
osortega
added a commit
that referenced
this pull request
Jan 25, 2026
Close welcome view when clicking on View all sessions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.