agent sessions - fix endless loop with maximising 2nd sidebar#290286
Merged
agent sessions - fix endless loop with maximising 2nd sidebar#290286
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an endless loop bug that occurred when maximizing the auxiliary bar (2nd sidebar). The fix enhances the onDidChangePartVisibility event to include information about which part changed visibility and whether it became visible or hidden, allowing listeners to react more precisely and avoid triggering unnecessary cascading visibility changes.
Changes:
- Enhanced
onDidChangePartVisibilityevent to passIPartVisibilityChangeEventwithpartIdandvisibleinformation - Updated the auxiliary bar maximization logic to only trigger when the sidebar or panel specifically hides (not on all visibility changes)
- Updated the test service mock to match the new event signature
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/services/layout/browser/layoutService.ts | Added IPartVisibilityChangeEvent interface and updated onDidChangePartVisibility event signature to use it |
| src/vs/workbench/browser/layout.ts | Updated emitter type and listener to use the new event payload, fixing the endless loop by only calling maybeMaximizeAuxiliaryBar() when sidebar/panel hides |
| src/vs/workbench/test/browser/workbenchTestServices.ts | Updated test service mock to match the new event signature |
bhavyaus
approved these changes
Jan 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.