Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request implements a new awaitTerminal tool that allows chat agents to wait for background terminal commands to complete, addressing issue #288565. This eliminates the need for agents to use workarounds like echo "finished" or sleep n commands when waiting for background tasks.
Changes:
- Adds a new
AwaitTerminalToolthat can wait for terminal executions with configurable timeout - Exposes an
IActiveTerminalExecutioninterface andgetExecution()method inRunInTerminalToolto allow other tools to access active terminal executions - Registers the new tool in the tool contribution system
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/awaitTerminalTool.ts | New tool implementation that waits for terminal completion with timeout support |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/runInTerminalTool.ts | Adds interface and static method to expose active terminal executions to other tools |
| src/vs/workbench/contrib/terminalContrib/chatAgentTools/browser/terminal.chatAgentTools.contribution.ts | Registers the new await terminal tool in the tool service |
lszomoru
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288565