Skip to content

refactor agentitlebarstatuswidget css for more consistent theming support#290525

Merged
joshspicer merged 4 commits intomainfrom
joshspicer/theming
Jan 26, 2026
Merged

refactor agentitlebarstatuswidget css for more consistent theming support#290525
joshspicer merged 4 commits intomainfrom
joshspicer/theming

Conversation

@joshspicer
Copy link
Copy Markdown
Member

@joshspicer joshspicer commented Jan 26, 2026

  • Testing against built-in themes (Dark/light/HC) and some select custom themes.
  • Removes duplicated css properties
  • Respects title bar color settings as a user would expect, eg:
    "workbench.colorCustomizations": {
        "titleBar.activeBackground": "#2196F3",
        "titleBar.activeForeground": "#FFFFFF"
    },

fixes #289830

Screen.Recording.2026-01-26.at.11.57.38.AM.mov

Copilot AI review requested due to automatic review settings January 26, 2026 19:56
@vs-code-engineering
Copy link
Copy Markdown
Contributor

vs-code-engineering bot commented Jan 26, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@bpasero

Matched files:

  • src/vs/workbench/contrib/chat/browser/agentSessions/experiments/media/agenttitlebarstatuswidget.css

@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 26, 2026
@joshspicer joshspicer enabled auto-merge (squash) January 26, 2026 20:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the Agent Title Bar Status Widget CSS to align styling with Command Center theme tokens so the widget respects title bar color customizations and reduces duplicated styling.

Changes:

  • Switched pill/badge colors to use --vscode-commandCenter-* tokens for more consistent theming behavior.
  • Consolidated duplicated layout/typography/icon rules and simplified selectors.
  • Adjusted high-contrast behavior for badge hover/filtered states.
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/agentSessions/experiments/media/agenttitlebarstatuswidget.css:237

  • .agent-status-badge-section.filtered changes the background to --vscode-inputOption-activeBackground but doesn’t set the matching foreground (--vscode-inputOption-activeForeground). This can make the count/icon unreadable in themes where active background expects a different foreground.
.agent-status-badge-section.filtered {
	background-color: var(--vscode-inputOption-activeBackground);
}

@joshspicer joshspicer disabled auto-merge January 26, 2026 20:01
alexdima
alexdima previously approved these changes Jan 26, 2026
…s/media/agenttitlebarstatuswidget.css

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s/media/agenttitlebarstatuswidget.css

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@joshspicer joshspicer enabled auto-merge (squash) January 26, 2026 21:08
@joshspicer joshspicer merged commit 2174f81 into main Jan 26, 2026
22 checks passed
@joshspicer joshspicer deleted the joshspicer/theming branch January 26, 2026 21:59
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Agent status doesn't piuck up custom title bar color.

4 participants