fix: update disk badge icons for dmg#290879
Merged
deepak1556 merged 3 commits intomainfrom Jan 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for badge icons on macOS DMG disk images as part of the DMG installation implementation for VS Code. The badge icon appears on the mounted disk image volume icon, improving the visual appearance and user experience of the DMG-based installation flow.
Changes:
- Updated distro repository commit hash to include the disk.icns resource file
- Added badge-icon support to the DMG build configuration
- Configured the DMG builder to use disk.icns as the badge icon for mounted volumes
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Updates the distro commit hash to pull in the new disk.icns resource |
| build/darwin/create-dmg.ts | Adds badge-icon property to DmgBuildSettings interface, defines diskIconPath variable, and configures the DMG builder to use the disk badge icon |
deepak1556
force-pushed
the
robo/fix_disk_icns
branch
from
66a3a62 to
53c9756
Compare
Refs dmgbuild/dmgbuild#278 which doesn't work well on macOS 26. We avoid forking the project in this manner.
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Collaborator
Author
|
bpasero
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291074
For #290683 (comment)