layout - reduce scope of workbench.secondarySideBar.forceMaximized to only apply when editors are closed#291293
Merged
layout - reduce scope of workbench.secondarySideBar.forceMaximized to only apply when editors are closed#291293
workbench.secondarySideBar.forceMaximized to only apply when editors are closed#291293Conversation
…to only apply when editors are closed We later need to revisit how a better layout would be for focus on sessions, but the current implementation has too many bugs.
Contributor
There was a problem hiding this comment.
Pull request overview
Refines the behavior and messaging of workbench.secondarySideBar.forceMaximized to reduce unintended layout side effects, focusing auxiliary bar maximization on scenarios where editors are not visible.
Changes:
- Adjusts the setting description for
workbench.secondarySideBar.forceMaximizedto better reflect intended behavior. - Simplifies the auxiliary bar auto-maximization trigger to depend only on “no visible editors”.
- Removes the “maximize on sidebar/panel hide” listener to reduce layout churn.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/browser/workbench.contribution.ts | Updates the user-facing description for the secondary sidebar force-maximized setting. |
| src/vs/workbench/browser/layout.ts | Narrows when auxiliary bar auto-maximization is triggered and removes a visibility-change hook. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Tyriar
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We later need to revisit how a better layout would be for focus on sessions, but the current implementation has too many bugs.
fix #291080