No intellisense docs for custom agent properties#291330
Merged
Conversation
bpasero
approved these changes
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where custom agent property suggestions in IntelliSense were missing documentation details. The fix extracts duplicate localization strings into a shared utility function and uses it to populate documentation in the autocompletion provider.
Changes:
- Created a shared
getAttributeDescriptionfunction to centralize attribute documentation strings across different prompt types - Refactored the hover provider to use the shared function instead of inline localized strings
- Added documentation to completion items in the autocompletion provider using the shared function
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptValidator.ts | Added getAttributeDescription function that returns localized documentation for prompt header attributes across all prompt types (instructions, skill, agent, prompt) |
| src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptHovers.ts | Refactored to use shared getAttributeDescription function instead of duplicating localized strings, simplifying the hover provider logic |
| src/vs/workbench/contrib/chat/common/promptSyntax/languageProviders/promptHeaderAutocompletion.ts | Added documentation field to completion items using getAttributeDescription, fixing the missing IntelliSense documentation issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291124