Remove inline chat affordance suppression logic#291350
Merged
Conversation
Users disliked that the inline chat affordance (sparkle icon) would only show once per selection and require changing the selection to see it again. This change removes the suppressAffordance mechanism so the affordance remains visible as long as there is a valid text selection. Fixes #291036
Tyriar
approved these changes
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the user experience by removing the suppressAffordance mechanism that caused the inline chat affordance (sparkle icon) to disappear after being dismissed once. The affordance now remains visible as long as there is a valid text selection, allowing users to dismiss the widget to see their code and then re-invoke it without changing the selection.
Changes:
- Removed the
suppressAffordanceobservable that controlled when to hide the affordance after first use - Removed logic that suppressed the affordance when the input widget was shown or positioned
- Cleaned up unused import (
isIOverlayWidgetPositionCoordinates)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| inlineChatAffordance.ts | Removed suppressAffordance observable declaration, removed autoruns that set it to true/false, removed references in constructor calls, cleaned up unused import |
| inlineChatGutterAffordance.ts | Removed suppressAffordance parameter from constructor and removed check in data derivation |
| inlineChatEditorAffordance.ts | Removed suppressAffordance parameter from constructor and removed suppression check in autorun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users disliked that the inline chat affordance (sparkle icon) would only show once per selection and require changing the selection to see it again. This change removes the suppressAffordance mechanism so the affordance remains visible as long as there is a valid text selection.
Fixes #291036