Skip to content

chat - drop option to hide chat title#291505

Merged
bpasero merged 2 commits intomainfrom
ben/musical-goat
Jan 29, 2026
Merged

chat - drop option to hide chat title#291505
bpasero merged 2 commits intomainfrom
ben/musical-goat

Conversation

@bpasero
Copy link
Copy Markdown
Member

@bpasero bpasero commented Jan 29, 2026

No description provided.

Copilot AI review requested due to automatic review settings January 29, 2026 08:12
@bpasero bpasero enabled auto-merge (squash) January 29, 2026 08:12
@bpasero bpasero self-assigned this Jan 29, 2026
@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 29, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the user-facing option to hide the chat title, making the chat title behavior no longer configurable via setting/command.

Changes:

  • Removed chat.viewTitle.enabled configuration and its ChatConfiguration enum entry.
  • Removed the “Show Chat Title” toggle action/command and the associated configuration listening in ChatViewTitleControl.
  • Minor cleanup in test stubs and test comments.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/vs/workbench/test/browser/workbenchTestServices.ts Removes a duplicate openSession overload in the test chat widget service stub.
src/vs/workbench/contrib/chat/test/browser/agentSessions/agentSessionViewModel.test.ts Removes now-unnecessary inline comments in session read-state tests.
src/vs/workbench/contrib/chat/common/constants.ts Drops ChatViewTitleEnabled from ChatConfiguration.
src/vs/workbench/contrib/chat/browser/widgetHosts/viewPane/chatViewTitleControl.ts Removes config dependency/listener and always renders title based on model title (no setting gate).
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Removes registration of the chat.viewTitle.enabled setting.
src/vs/workbench/contrib/chat/browser/actions/chatActions.ts Removes the toggle action/command that updated chat.viewTitle.enabled.

@bpasero bpasero merged commit e7ac236 into main Jan 29, 2026
22 checks passed
@bpasero bpasero deleted the ben/musical-goat branch January 29, 2026 08:34
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants