Add secondary button border and update related styles and colors#291556
Merged
mrleemurray merged 1 commit intomainfrom Jan 29, 2026
Merged
Add secondary button border and update related styles and colors#291556mrleemurray merged 1 commit intomainfrom
mrleemurray merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a secondary button border feature to improve visual consistency and usability of secondary buttons throughout VS Code. The changes include new color definitions, updates to the button component to handle borders, and updates to extension action styling.
Changes:
- Added
buttonSecondaryBordercolor with 20% transparent foreground color - Updated secondary button colors: foreground now uses default text color, background is transparent, hover uses list hover background
- Modified Button component to apply borders based on button type (primary vs secondary)
- Updated extension button styling to use the new border color
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/theme/common/colors/inputColors.ts | Added buttonSecondaryBorder color definition and updated secondary button colors (foreground, background, hover) to align with new design |
| src/vs/base/browser/ui/button/button.ts | Extended IButtonStyles interface with buttonSecondaryBorder, updated button constructor and updateStyles method to apply border based on button type |
| src/vs/platform/theme/browser/defaultStyles.ts | Added buttonSecondaryBorder to imports and default button styles export |
| src/vs/workbench/contrib/extensions/browser/extensionsActions.ts | Registered extensionButton.border color that references buttonSecondaryBorder |
| src/vs/workbench/contrib/extensions/browser/media/extensionActions.css | Updated CSS to use --vscode-extensionButton-border variable for borders and separator dividers |
| build/lib/stylelint/vscode-known-variables.json | Added new CSS variables --vscode-button-secondaryBorder and --vscode-extensionButton-border to known variables list |
dbaeumer
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a secondary button border along with updates to related styles and colors. This enhancement improves the visual consistency and usability of secondary buttons in the interface.
Addresses: #290938