Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the theme IDs and labels for the experimental 2026 themes to improve clarity and naming consistency.
Changes:
- Theme IDs changed from
2026-light-experimental/2026-dark-experimentaltoExperimental Light/Experimental Dark - Theme labels changed from
2026 Light/2026 DarktoVS Code Light/VS Code Dark
| "id": "Experimental Light", | ||
| "label": "VS Code Light", |
There was a problem hiding this comment.
The theme label "VS Code Light" may be confusing for users because:
- There are existing themes with similar names: "Visual Studio Light" (ID: "Visual Studio Light") and "Light (Visual Studio)" are already present in the theme-defaults extension
- "VS Code" and "Visual Studio" are different products, which could cause user confusion
- The extension itself is named "2026 Themes" (theme-2026), making "VS Code Light" inconsistent with the extension's identity
Consider using a label that better reflects the extension name, such as "2026 Light" or a more distinctive name that doesn't overlap with existing themes.
| "id": "Experimental Dark", | ||
| "label": "VS Code Dark", |
There was a problem hiding this comment.
The theme label "VS Code Dark" may be confusing for users because:
- There are existing themes with similar names: "Visual Studio Dark" (ID: "Visual Studio Dark") and "Dark (Visual Studio)" are already present in the theme-defaults extension
- "VS Code" and "Visual Studio" are different products, which could cause user confusion
- The extension itself is named "2026 Themes" (theme-2026), making "VS Code Dark" inconsistent with the extension's identity
Consider using a label that better reflects the extension name, such as "2026 Dark" or a more distinctive name that doesn't overlap with existing themes.
| { | ||
| "id": "2026-light-experimental", | ||
| "label": "2026 Light", | ||
| "id": "Experimental Light", |
There was a problem hiding this comment.
The PR description states the change is from "2026 Light / Dark" to "VS Code Light / Dark" but doesn't mention that the theme IDs are also being changed from "2026-light-experimental" / "2026-dark-experimental" to "Experimental Light" / "Experimental Dark".
Theme IDs are what users reference in their settings (e.g., "workbench.colorTheme": "Experimental Light"), so changing them is a breaking change for anyone who has already configured these themes in their settings. The PR description should clearly document this breaking change.
Revise theme IDs and labels to ensure consistency across the application.
2026 Light / Dark->VS Code Light / DarkThis change enhances clarity and aligns with standard naming conventions. Testing can be done by verifying the updated themes in the settings.