Fixes https://github.com/microsoft/vscode/issues/291242#291760
Merged
Conversation
dmitrivMS
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces the 10-minute focus survival telemetry window with a 20-minute focus survival window as requested in issue #291242. The change maintains the existing 5-minute wall-clock window while updating the focus-time-based window to provide longer-term telemetry data.
Changes:
- Updated the focus window duration from 10 minutes to 20 minutes in the implementation
- Updated test expectations to reflect the new 20-minute timing
- Updated all telemetry event documentation and mode strings to reference "20minFocusWindow" instead of "10minFocusWindow"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/editTelemetry/browser/telemetry/editSourceTrackingImpl.ts | Updated focus window timer from 10 to 20 minutes, changed mode parameter type and telemetry documentation strings |
| src/vs/workbench/contrib/editTelemetry/test/browser/editTelemetry.test.ts | Updated test timeout from 8 to 18 minutes and expected telemetry timestamps/values to match new 20-minute window |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291242