Skip to content

Fix terminal persistence test flake on Windows#294683

Merged
Tyriar merged 3 commits intotyriar/291275from
copilot/fix-github-actions-workflow-again
Feb 11, 2026
Merged

Fix terminal persistence test flake on Windows#294683
Tyriar merged 3 commits intotyriar/291275from
copilot/fix-github-actions-workflow-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 11, 2026

Terminal detach/attach smoke test was timing out on Windows when attempting to reattach by name. The terminal title format includes dynamic content by default, causing name mismatch between capture (line 39) and use (line 46).

Changes

Configure terminal.integrated.tabs.title to ${process} in test setup to ensure stable, predictable terminal names for the detach/attach flow.

await setTerminalTestSettings(app, [
    ['terminal.integrated.tabs.title', '"${process}"']
]);

Scope: Single test suite configuration change, no product code affected.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Set terminal.integrated.tabs.title to ${process} to ensure consistent
terminal names for detach/attach operations in the smoke test. This
prevents name mismatches on Windows where the default title format
may include dynamic content.

Fixes failing test: Terminal Persistence -> detach/attach -> should support basic reconnection

Co-authored-by: Tyriar <2193314+Tyriar@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow for Windows/Electron Fix terminal persistence test flake on Windows Feb 11, 2026
Copilot AI requested a review from Tyriar February 11, 2026 21:23
@Tyriar Tyriar changed the base branch from main to tyriar/291275 February 11, 2026 21:53
@Tyriar Tyriar marked this pull request as ready for review February 11, 2026 21:54
@Tyriar Tyriar merged commit c8f8ddc into tyriar/291275 Feb 11, 2026
5 of 6 checks passed
@Tyriar Tyriar deleted the copilot/fix-github-actions-workflow-again branch February 11, 2026 21:55
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Mar 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants