Skip to content

kill the working spinner and some thinking header fixes#295403

Merged
justschen merged 4 commits intomainfrom
justin/excadrill
Feb 15, 2026
Merged

kill the working spinner and some thinking header fixes#295403
justschen merged 4 commits intomainfrom
justin/excadrill

Conversation

@justschen
Copy link
Copy Markdown
Collaborator

@justschen justschen commented Feb 15, 2026

removes the working spinner from progress part and defaults to shimmer, unless explicitely not added

Copilot AI review requested due to automatic review settings February 15, 2026 03:53
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request replaces spinner-based loading indicators with shimmer animations in the chat UI and removes ellipses ("...") from "Working..." status messages. The changes create a more refined visual experience by using gradient-based shimmer effects instead of rotating spinners, and make status messages more concise.

Changes:

  • Replaced Codicon.loading spinner icons with Codicon.circleFilled combined with shimmer animations
  • Removed ellipses from "Working...", "Thinking...", and similar status messages across localized strings
  • Added shimmer property to IChatProgressMessage interface to control shimmer animation behavior

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
chatService.ts Added optional shimmer boolean property to IChatProgressMessage interface
chat.css Added shimmer-progress class to hide spinner icon and apply shimmer animation
chatListRenderer.ts Passed shimmer flag from IChatProgressMessage to ChatProgressContentPart constructor
chatToolStreamingSubPart.ts Added undefined shimmer parameter when instantiating ChatProgressContentPart
chatToolProgressPart.ts Added undefined shimmer parameter when instantiating ChatProgressContentPart
chatThinkingContent.css Added shimmer animation styles for thinking header title with chat-thinking-active class
chatSubagentContent.css Added shimmer animation styles for subagent title display (duplicates thinking styles)
chatThinkingContentPart.ts Implemented shimmer title rendering with proper disposal, changed spinner to circle-filled, removed ellipses from messages
chatTaskContentPart.ts Added undefined shimmer parameter when instantiating ChatProgressContentPart
chatSubagentContentPart.ts Implemented shimmer title rendering for subagent parts, changed spinner to circle-filled
chatProgressContentPart.ts Added shimmer parameter and logic to use shimmer animation instead of spinner, removed ellipsis from "Working..." message
chatMcpServersInteractionContentPart.ts Enabled shimmer animation for MCP server progress messages
chatSetupProviders.ts Removed ellipses from setup messages and enabled shimmer flag for progress indicators
Comments suppressed due to low confidence (1)

src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatSubagentContentPart.ts:370

  • Memory leak: The rendered markdown object (result) is not being disposed before being replaced. Each call to updateTitle() creates a new IRenderedMarkdown via chatContentMarkdownRenderer.render(), but the previous result is not disposed when titleDetailContainer is replaced. This should store the IRenderedMarkdown in a field (similar to titleDetailRendered in chatThinkingContentPart.ts) and dispose it before creating a new one.
		}
		this.finalizeTitle();
		// Collapse when done
		this.setExpanded(false);
	}

	public finalizeTitle(): void {
		this.updateTitle();
		if (this._collapseButton) {
			this._collapseButton.icon = Codicon.check;

@justschen justschen marked this pull request as ready for review February 15, 2026 08:00
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 15, 2026
@justschen justschen merged commit 9bc20cc into main Feb 15, 2026
18 checks passed
@justschen justschen deleted the justin/excadrill branch February 15, 2026 08:14
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Apr 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants