kill the working spinner and some thinking header fixes#295403
Merged
kill the working spinner and some thinking header fixes#295403
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request replaces spinner-based loading indicators with shimmer animations in the chat UI and removes ellipses ("...") from "Working..." status messages. The changes create a more refined visual experience by using gradient-based shimmer effects instead of rotating spinners, and make status messages more concise.
Changes:
- Replaced
Codicon.loadingspinner icons withCodicon.circleFilledcombined with shimmer animations - Removed ellipses from "Working...", "Thinking...", and similar status messages across localized strings
- Added
shimmerproperty toIChatProgressMessageinterface to control shimmer animation behavior
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| chatService.ts | Added optional shimmer boolean property to IChatProgressMessage interface |
| chat.css | Added shimmer-progress class to hide spinner icon and apply shimmer animation |
| chatListRenderer.ts | Passed shimmer flag from IChatProgressMessage to ChatProgressContentPart constructor |
| chatToolStreamingSubPart.ts | Added undefined shimmer parameter when instantiating ChatProgressContentPart |
| chatToolProgressPart.ts | Added undefined shimmer parameter when instantiating ChatProgressContentPart |
| chatThinkingContent.css | Added shimmer animation styles for thinking header title with chat-thinking-active class |
| chatSubagentContent.css | Added shimmer animation styles for subagent title display (duplicates thinking styles) |
| chatThinkingContentPart.ts | Implemented shimmer title rendering with proper disposal, changed spinner to circle-filled, removed ellipses from messages |
| chatTaskContentPart.ts | Added undefined shimmer parameter when instantiating ChatProgressContentPart |
| chatSubagentContentPart.ts | Implemented shimmer title rendering for subagent parts, changed spinner to circle-filled |
| chatProgressContentPart.ts | Added shimmer parameter and logic to use shimmer animation instead of spinner, removed ellipsis from "Working..." message |
| chatMcpServersInteractionContentPart.ts | Enabled shimmer animation for MCP server progress messages |
| chatSetupProviders.ts | Removed ellipses from setup messages and enabled shimmer flag for progress indicators |
Comments suppressed due to low confidence (1)
src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatSubagentContentPart.ts:370
- Memory leak: The rendered markdown object (result) is not being disposed before being replaced. Each call to updateTitle() creates a new IRenderedMarkdown via chatContentMarkdownRenderer.render(), but the previous result is not disposed when titleDetailContainer is replaced. This should store the IRenderedMarkdown in a field (similar to titleDetailRendered in chatThinkingContentPart.ts) and dispose it before creating a new one.
}
this.finalizeTitle();
// Collapse when done
this.setExpanded(false);
}
public finalizeTitle(): void {
this.updateTitle();
if (this._collapseButton) {
this._collapseButton.icon = Codicon.check;
DonJayamanne
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes the working spinner from progress part and defaults to shimmer, unless explicitely not added