Skip to content

Remove code-no-native-private ESLint rule#295535

Merged
jrieken merged 1 commit intomainfrom
joh/remove-no-native-private-eslint
Feb 16, 2026
Merged

Remove code-no-native-private ESLint rule#295535
jrieken merged 1 commit intomainfrom
joh/remove-no-native-private-eslint

Conversation

@jrieken
Copy link
Copy Markdown
Member

@jrieken jrieken commented Feb 16, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 16, 2026 08:17
@jrieken jrieken enabled auto-merge (squash) February 16, 2026 08:17
@jrieken jrieken self-assigned this Feb 16, 2026
@vs-code-engineering
Copy link
Copy Markdown
Contributor

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • extensions/git/src/api/api1.ts

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the code-no-native-private ESLint rule from the codebase. The rule previously warned against using native private fields (the # syntax) due to performance concerns, but this restriction is no longer needed. The PR cleanly removes the rule implementation, its registration in the ESLint configuration, and all disable comments from files that were using private fields.

Changes:

  • Removed the custom ESLint rule code-no-native-private implementation
  • Removed the rule from the ESLint configuration
  • Removed all eslint-disable local/code-no-native-private comments from source files that were suppressing the rule

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
.eslint-plugin-local/code-no-native-private.ts Deleted the entire ESLint rule implementation file that warned against native private fields
eslint.config.js Removed the local/code-no-native-private rule from the ESLint configuration
src/vs/workbench/api/common/extHostWebviewView.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostWebviewPanels.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostWebview.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostTypes/notebooks.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostTypes/markdownString.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostTypes.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostTesting.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostTask.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostStatusBar.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostSecrets.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostSCM.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostExtensionService.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostDiagnostics.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostCommands.ts Removed eslint-disable comment for the obsolete rule
src/vs/workbench/api/common/extHostChatSessions.ts Removed eslint-disable comment for the obsolete rule
extensions/git/src/api/api1.ts Removed eslint-disable comment for the obsolete rule

@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 16, 2026
@jrieken jrieken merged commit 4f5d8f3 into main Feb 16, 2026
24 checks passed
@jrieken jrieken deleted the joh/remove-no-native-private-eslint branch February 16, 2026 09:03
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Apr 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants