Remove code-no-native-private ESLint rule#295535
Merged
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @lszomoruMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the code-no-native-private ESLint rule from the codebase. The rule previously warned against using native private fields (the # syntax) due to performance concerns, but this restriction is no longer needed. The PR cleanly removes the rule implementation, its registration in the ESLint configuration, and all disable comments from files that were using private fields.
Changes:
- Removed the custom ESLint rule
code-no-native-privateimplementation - Removed the rule from the ESLint configuration
- Removed all
eslint-disable local/code-no-native-privatecomments from source files that were suppressing the rule
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.eslint-plugin-local/code-no-native-private.ts |
Deleted the entire ESLint rule implementation file that warned against native private fields |
eslint.config.js |
Removed the local/code-no-native-private rule from the ESLint configuration |
src/vs/workbench/api/common/extHostWebviewView.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostWebviewPanels.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostWebview.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostTypes/notebooks.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostTypes/markdownString.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostTypes.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostTesting.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostTask.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostStatusBar.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostSecrets.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostSCM.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostExtensionService.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostDiagnostics.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostCommands.ts |
Removed eslint-disable comment for the obsolete rule |
src/vs/workbench/api/common/extHostChatSessions.ts |
Removed eslint-disable comment for the obsolete rule |
extensions/git/src/api/api1.ts |
Removed eslint-disable comment for the obsolete rule |
dbaeumer
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.