Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts Action Widget (code action menu) keyboard behavior to better support filtering and keep the context view correctly laid out while the visible list changes.
Changes:
- Adds an
Escapekeybinding scoped to the filter input to clear the filter (and hide if already empty). - Refactors
ActionListfiltering/layout to always relayout/reposition the context view after the list content changes. - Moves filter-input keyboard navigation responsibilities from an input
keydownlistener intofocusNext/focusPreviousbehaviors.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/platform/actionWidget/browser/actionWidget.ts |
Adds a clearFilter service method and a filter-focused Escape action to clear/hide appropriately. |
src/vs/platform/actionWidget/browser/actionList.ts |
Removes filter input keydown navigation handling, adds clearFilter(), updates focus wrap behavior, and ensures context view layout updates after filtering. |
dmitrivMS
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.