Skip to content

Debug panel fixes#297804

Merged
vijayupadya merged 1 commit intomainfrom
vijayu/dbgPanel-fixes
Feb 25, 2026
Merged

Debug panel fixes#297804
vijayupadya merged 1 commit intomainfrom
vijayu/dbgPanel-fixes

Conversation

@vijayupadya
Copy link
Copy Markdown
Contributor

Fixes https://github.com/microsoft/vscode-internalbacklog/issues/6905, https://github.com/microsoft/vscode-internalbacklog/issues/6862

Fix 1: [object Object] in debug panel
extHostChatDebug.ts — typeof checks in the default fallback of _serializeEvent() to drop non-string name/details
chatDebugEventList.ts — safeStr() helper that returns '' for non-strings, with '(unknown)' fallback for name fields

Fix 2: Indefinite spinner for new sessions on home page
chatDebugHomeView.ts — Only show shimmer when the title is a UUID and no live model exists, not for new sessions that simply have no requests yet

Copilot AI review requested due to automatic review settings February 25, 2026 22:12
@vijayupadya vijayupadya marked this pull request as ready for review February 25, 2026 22:14
@vijayupadya vijayupadya enabled auto-merge (squash) February 25, 2026 22:14
@vs-code-engineering vs-code-engineering bot added this to the February 2026 milestone Feb 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses two user-facing issues in the Chat Debug (Agent Debug Panel) UI: preventing [object Object] from appearing in debug event rows, and avoiding an indefinite loading shimmer/spinner for new sessions on the debug home page.

Changes:

  • Gate the home view “shimmer” state on both UUID-like titles and absence of a live session model.
  • Add string-sanitization in the debug event list rendering to avoid rendering non-string values as [object Object].
  • Harden ext host event serialization fallback to drop non-string name/details for generic events.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugHomeView.ts Adjusts shimmer logic so new/live sessions don’t show an indefinite spinner.
src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugEventList.ts Adds safeStr and uses it when rendering event name/details to avoid [object Object].
src/vs/workbench/api/common/extHostChatDebug.ts Filters non-string name/details in the default serialization fallback.

@vijayupadya vijayupadya merged commit 62cd38b into main Feb 25, 2026
24 checks passed
@vijayupadya vijayupadya deleted the vijayu/dbgPanel-fixes branch February 25, 2026 22:28
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Apr 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants