Merged
Conversation
pwang347
approved these changes
Feb 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses two user-facing issues in the Chat Debug (Agent Debug Panel) UI: preventing [object Object] from appearing in debug event rows, and avoiding an indefinite loading shimmer/spinner for new sessions on the debug home page.
Changes:
- Gate the home view “shimmer” state on both UUID-like titles and absence of a live session model.
- Add string-sanitization in the debug event list rendering to avoid rendering non-string values as
[object Object]. - Harden ext host event serialization fallback to drop non-string
name/detailsfor generic events.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugHomeView.ts | Adjusts shimmer logic so new/live sessions don’t show an indefinite spinner. |
| src/vs/workbench/contrib/chat/browser/chatDebug/chatDebugEventList.ts | Adds safeStr and uses it when rendering event name/details to avoid [object Object]. |
| src/vs/workbench/api/common/extHostChatDebug.ts | Filters non-string name/details in the default serialization fallback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/microsoft/vscode-internalbacklog/issues/6905, https://github.com/microsoft/vscode-internalbacklog/issues/6862
Fix 1: [object Object] in debug panel
extHostChatDebug.ts — typeof checks in the default fallback of _serializeEvent() to drop non-string name/details
chatDebugEventList.ts — safeStr() helper that returns '' for non-strings, with '(unknown)' fallback for name fields
Fix 2: Indefinite spinner for new sessions on home page
chatDebugHomeView.ts — Only show shimmer when the title is a UUID and no live model exists, not for new sessions that simply have no requests yet