Improve sanity tests stability

[dmitrivMS]

Capture and upload screenshots when errors occur.
Close app and browser even if test fails.
Improve waiting logic and add retries in flaky places (such as Extensions view).

[Copilot]

Pull request overview

This PR aims to make the sanity (Playwright-based) UI tests more reliable and debuggable by replacing fixed delays with state-based waits and by capturing/publishing screenshots on failures in CI.

Changes:

• Replace brittle waitForTimeout usage in UI flows with more deterministic waits (e.g., waiting for the command palette to close, waiting for search results/buttons).
• Add failure screenshot capture support in TestContext, plus a CLI option (--screenshots-dir) to control where screenshots are written.
• Update the Azure Pipelines sanity job to create a screenshots directory, pass it into the test run, and publish it as a pipeline artifact.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
test/sanity/src/uiTest.ts	Improves UI interaction stability by using typed input and state-based waits instead of fixed sleeps.
test/sanity/src/main.ts	Wires screenshotsDir into TestContext from CLI options (but currently misses -s alias support).
test/sanity/src/index.ts	Adds --screenshots-dir, -s to the CLI help/options for the sanity test runner.
test/sanity/src/context.ts	Captures a screenshot of the active Playwright page when a test fails.
build/azure-pipelines/common/sanity-tests.yml	Creates/publishes a screenshots artifact and passes a screenshots directory to sanity test runs.

Comments suppressed due to low confidence (1)

test/sanity/src/main.ts:20

• -s/--screenshots-dir is documented and used by the pipeline, but main.ts doesn't define an alias for -s. With the current minimist config, -s <path> will populate options.s instead of options['screenshots-dir'], so screenshotsDir will always be undefined when the short flag is used. Add {'screenshots-dir': 's'} to the alias map here (or switch callers to use --screenshots-dir).

const options = minimist(process.argv.slice(2), {
	string: ['commit', 'quality', 'screenshots-dir'],
	boolean: ['cleanup', 'verbose', 'signing-check', 'headless', 'detection'],
	alias: { commit: 'c', quality: 'q', verbose: 'v' },
	default: { cleanup: true, verbose: false, 'signing-check': true, headless: true, 'detection': true },
});

[vs-code-engineering]

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

• build/azure-pipelines/common/sanity-tests.yml