updates screenshot pipeline & baseline#298264
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the screenshot testing pipeline and adds new screenshot baselines for VS Code's component testing infrastructure. The PR simplifies the GitHub Actions workflow by replacing check runs with commit statuses, which improves security by reducing required permissions but trades off some visibility features.
Changes:
- Simplified screenshot workflow permissions from
pull-requests: writeandchecks: writeto onlystatuses: write - Replaced check run creation logic with simpler commit status API calls
- Added visual emoji indicators (
⚠️ /✅) to status titles for better at-a-glance feedback - Added 64 new screenshot baselines for UI components (updateWidget states, chatQuestionCarousel, and other UI elements)
- Updated 1 existing screenshot baseline (aiStats/AiStatsHover/Dark)
Reviewed changes
Copilot reviewed 3 out of 161 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/screenshot-test.yml | Simplified workflow permissions and reporting mechanism; removed check run logic in favor of commit statuses |
| .tmp/screenshot-diff/report/* | Generated screenshot comparison report and current screenshots (64 added, 1 changed) |
| .tmp/screenshot-diff/current/* | Current screenshot outputs from test run |
Comments suppressed due to low confidence (1)
.github/workflows/screenshot-test.yml:13
- The removal of
pull-requests: writeandchecks: writepermissions is a significant security improvement, limiting the workflow to only the necessarystatuses: writepermission. However, this change means the workflow can no longer create check runs (which requirechecks: write). The new approach using commit statuses is appropriate for fork PRs but provides less detailed feedback than check runs. Consider documenting this trade-off in the workflow or commit message.
permissions:
contents: read
statuses: write
auto-merge was automatically disabled
February 27, 2026 14:45
Pull request was converted to draft
809ab72 to
a1d91a6
Compare
bpasero
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.