Skip to content

updates screenshot pipeline & baseline#298264

Merged
hediet merged 2 commits intomainfrom
hediet/b/elaborate-weasel
Feb 27, 2026
Merged

updates screenshot pipeline & baseline#298264
hediet merged 2 commits intomainfrom
hediet/b/elaborate-weasel

Conversation

@hediet
Copy link
Copy Markdown
Member

@hediet hediet commented Feb 27, 2026

No description provided.

Copilot AI review requested due to automatic review settings February 27, 2026 14:41
@hediet hediet enabled auto-merge (rebase) February 27, 2026 14:41
@hediet hediet self-assigned this Feb 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the screenshot testing pipeline and adds new screenshot baselines for VS Code's component testing infrastructure. The PR simplifies the GitHub Actions workflow by replacing check runs with commit statuses, which improves security by reducing required permissions but trades off some visibility features.

Changes:

  • Simplified screenshot workflow permissions from pull-requests: write and checks: write to only statuses: write
  • Replaced check run creation logic with simpler commit status API calls
  • Added visual emoji indicators (⚠️/✅) to status titles for better at-a-glance feedback
  • Added 64 new screenshot baselines for UI components (updateWidget states, chatQuestionCarousel, and other UI elements)
  • Updated 1 existing screenshot baseline (aiStats/AiStatsHover/Dark)

Reviewed changes

Copilot reviewed 3 out of 161 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/screenshot-test.yml Simplified workflow permissions and reporting mechanism; removed check run logic in favor of commit statuses
.tmp/screenshot-diff/report/* Generated screenshot comparison report and current screenshots (64 added, 1 changed)
.tmp/screenshot-diff/current/* Current screenshot outputs from test run
Comments suppressed due to low confidence (1)

.github/workflows/screenshot-test.yml:13

  • The removal of pull-requests: write and checks: write permissions is a significant security improvement, limiting the workflow to only the necessary statuses: write permission. However, this change means the workflow can no longer create check runs (which require checks: write). The new approach using commit statuses is appropriate for fork PRs but provides less detailed feedback than check runs. Consider documenting this trade-off in the workflow or commit message.
permissions:
  contents: read
  statuses: write

Comment thread .github/workflows/screenshot-test.yml
Comment thread .github/workflows/screenshot-test.yml
@hediet hediet marked this pull request as draft February 27, 2026 14:45
auto-merge was automatically disabled February 27, 2026 14:45

Pull request was converted to draft

@hediet hediet force-pushed the hediet/b/elaborate-weasel branch from 809ab72 to a1d91a6 Compare February 27, 2026 14:59
@hediet hediet changed the title updates screenshot pipeline & baselineI updates screenshot pipeline & baseline Feb 27, 2026
@hediet hediet marked this pull request as ready for review February 27, 2026 16:41
@hediet hediet enabled auto-merge (rebase) February 27, 2026 16:55
@hediet hediet merged commit 77ec174 into main Feb 27, 2026
29 of 30 checks passed
@hediet hediet deleted the hediet/b/elaborate-weasel branch February 27, 2026 16:58
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Apr 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants