fixes vscode-internalbacklog#6911

[isidorn]

cc @ivy-lai-miller @kevin-m-kent

I call it conversationId? Does that make sense or should it be sessionId?

fixes vscode-internalbacklog#6911

[Copilot]

Pull request overview

This pull request adds tracking for chat session and request identifiers in edit telemetry to help correlate edits with their originating chat sessions. The change addresses an internal backlog item (vscode-internalbacklog#6911) by adding two new telemetry fields to capture the chat conversation/session context when edits originate from chat features.

Changes:

• Added conversationId and requestId fields to the editTelemetry.editSources.details telemetry event
• Added telemetry metadata classifications for these new fields to comply with data governance requirements

Comments suppressed due to low confidence (2)

src/vs/workbench/contrib/editTelemetry/browser/telemetry/editSourceTrackingImpl.ts:216

• The telemetry field is named conversationId but should be editSessionId to match the existing pattern in arcTelemetrySender.ts (line 185). Both fields source from data.props.$$sessionId, and in the arc telemetry the field is named editSessionId with the comment "The session id."

This naming inconsistency could cause confusion when analyzing telemetry data. The term "editSessionId" is more appropriate here since it refers to the chat session ID (not a conversation ID), and consistency across telemetry events is important for data analysis.

				conversationId: string | undefined;
				requestId: string | undefined;

src/vs/workbench/contrib/editTelemetry/browser/telemetry/editSourceTrackingImpl.ts:234

• The telemetry field comment refers to "conversationId" but the field is being named conversationId in the current implementation. However, this should be changed to match the existing pattern. In arcTelemetrySender.ts (line 209), the corresponding field is named editSessionId with comment "The session id."

For consistency, this comment should be updated to match the naming convention used in the arc telemetry event. The comment should describe it as a session identifier (or edit session identifier) rather than a conversation identifier, since the underlying data comes from the chat session ID.

				conversationId: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The chat conversation identifier when the edit source comes from chat. Sourced from the chat edit session id.' };

[mjbvz]

Moving this to 1.112 and disabling auto merge so that we can get the 1.111 milestone into good shape by the end of Thursday

Please take this in as a candidate if it must go into 1.111