fix chat question carousel with title row and styling#298366
Merged
meganrogge merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the chat question carousel header/titlebar layout regression reported in #298362 by introducing an explicit “title row” container and adjusting the header/title styling so the title and close button lay out correctly.
Changes:
- Add a
.chat-question-title-rowwrapper to structure the header into a dedicated flex row for title + close button. - Update rendering to append the title and close button into the new title row, then mount that row into the header container.
- Refactor/re-scope header/title CSS so markdown/title styling remains applied while supporting the new DOM structure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/media/chatQuestionCarousel.css | Adds styling for the new title row and keeps title/markdown styling working within the updated header structure. |
| src/vs/workbench/contrib/chat/browser/widget/chatContentParts/chatQuestionCarouselPart.ts | Updates header rendering to introduce a title-row element and place the title + close button within it. |
DonJayamanne
pushed a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #298362