Conversation
osortega
approved these changes
Feb 28, 2026
osortega
previously approved these changes
Feb 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes how a repository is set when creating a new cloud (remote) agent session. Previously, the RepoPicker was calling session.setOption('repositories', item) directly, and RemoteNewSession.setRepoUri was incorrectly calling setOption('repository', uri.fsPath). The fix centralizes repo-setting logic through a new _setRepo helper in RepoPicker, routes it through setRepoUri, and constructs the correct repositories option format ({ id, name }) for cloud sessions.
Changes:
- Added
_setRepo()helper toRepoPickerthat constructs ahttps://github.com/{repo.id}URI and callssetRepoUrion the session, replacing directsetOptioncalls. - Updated
RemoteNewSession.setRepoUri()to extractowner/repofrom the URI path and set therepositoriesoption with a properly structured{ id, name }object. - Fixed
_setNewSessioninNewChatWidgetto wire pickers conditionally based on session target (Background vs Cloud), and updatedgetActiveSessionFolderDatato only return folder data for Background sessions (not Cloud).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
repoPicker.ts |
Adds URI import; extracts _setRepo() helper that calls setRepoUri instead of setOption('repositories', ...) directly |
newSession.ts |
Fixes RemoteNewSession.setRepoUri to use uri.path.substring(1) to extract owner/repo and pass it as a repositories option item |
newChatViewPane.ts |
Wires pickers to sessions conditionally by target type (Background → folder/isolation/branch; Cloud → repo) |
workspaceFolderManagement.ts |
Fixes guard to only skip undefined sessions; restricts workspace folder assignment to Background sessions only (Cloud case commented out) |
osortega
approved these changes
Feb 28, 2026
DonJayamanne
pushed a commit
that referenced
this pull request
Mar 2, 2026
* set remote repo uri * fix setting repo * fix setting repo uri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.