Clean up model picker input styles#298460
Merged
daviddossett merged 2 commits intomainfrom Feb 28, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Chat model picker dropdown’s filter input styling to better match the action widget’s visual design after prior focus-outline changes.
Changes:
- Makes the model picker filter input background transparent.
- Adds extra spacing below the filter area by applying a margin to its container.
- Adds a runtime class to the filter container to target the new spacing rule.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/chat/browser/widget/media/chat.css | Removes filter input background and adds container margin styling for spacing. |
| src/vs/workbench/contrib/chat/browser/widget/input/chatModelPicker.ts | Adds a CSS class to the filter container at runtime to enable the new spacing rule. |
daviddossett
changed the title
lszomoru
approved these changes
Feb 28, 2026
DonJayamanne
pushed a commit
that referenced
this pull request
Mar 2, 2026
* Clean up model picker input styles: remove background, add filter spacing * Use CSS :has() instead of imperative class for filter container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up leftover model picker input styles after the focus outline removal: