Port github-authentication extension to use esbuild#298808
Merged
mjbvz merged 2 commits intomicrosoft:mainfrom Mar 2, 2026
Merged
Port github-authentication extension to use esbuild#298808mjbvz merged 2 commits intomicrosoft:mainfrom
mjbvz merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @TylerLeonhardtMatched files:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Ports the github-authentication extension’s web build pipeline from webpack to the repo’s shared esbuild extension build tooling, aligning it with how other built-in extensions produce browser bundles.
Changes:
- Replaces webpack-based
compile-web/watch-webscripts with anesbuild.browser.mtsbuild. - Removes the browser webpack config and introduces an esbuild browser plugin to remap
./node/*imports to./browser/*. - Adds a browser tsconfig and adjusts packaging ignore rules for the new build scripts.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| extensions/github-authentication/tsconfig.browser.json | Adds a browser-specific tsconfig excluding node + tests. |
| extensions/github-authentication/src/browser/authServer.ts | Adds a browser-side export stub for LoopbackAuthServer. |
| extensions/github-authentication/package.json | Switches web build/watch scripts to esbuild. |
| extensions/github-authentication/extension-browser.webpack.config.js | Removes webpack browser config. |
| extensions/github-authentication/esbuild.mts | Converts prior config into an esbuild-based build script for node bundling. |
| extensions/github-authentication/esbuild.browser.mts | Adds esbuild browser build + import remapping plugin. |
| extensions/github-authentication/.vscodeignore | Updates ignore list to exclude esbuild scripts instead of webpack configs. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
DonJayamanne
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bit more difficult than others since it requires path mapping