Fix terminal-suggest extension icon#299397
Merged
mjbvz merged 1 commit intomicrosoft:mainfrom Mar 6, 2026
Merged
Conversation
Same root cause as microsoft#299396 but only caused the icon to be missing so not critical
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the terminal-suggest built-in extension icon not appearing by moving the icon asset out of src/ (which is excluded during extension packaging/bundling) and updating the manifest to reference the new location.
Changes:
- Update
extensions/terminal-suggest/package.jsonto pointiconat./media/icon.png. - Add the icon asset at
extensions/terminal-suggest/media/icon.pngso it’s included in the packaged extension (since.vscodeignoreexcludessrc/**but notmedia/**).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| extensions/terminal-suggest/package.json | Updates the extension manifest icon path to a non-excluded folder. |
| extensions/terminal-suggest/media/icon.png | Adds the icon asset in media/ so it ships with the extension. |
bpasero
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same root cause as #299396 but only caused the icon to be missing so it didn't show up in testing
Simple fix is to just move the icon out of
srcsince the entiresrcdir is removed during bundling