Skip to content

chat: register file system provider via workbench contribution#299528

Merged
connor4312 merged 2 commits intomainfrom
connor4312/299504
Mar 6, 2026
Merged

chat: register file system provider via workbench contribution#299528
connor4312 merged 2 commits intomainfrom
connor4312/299504

Conversation

@connor4312
Copy link
Copy Markdown
Member

@connor4312 connor4312 commented Mar 5, 2026

  • Moves the registerProvider call from ChatResponseResourceFileSystemProvider constructor
    to a new ChatResponseResourceWorkbenchContribution class that gets instantiated by
    the workbench. This ensures the vscode-chat-response-resource:// file system provider
    is registered even though the service has no other dependencies that would trigger
    eager instantiation.
  • Changes the singleton registration from Eager to Delayed since the workbench
    contribution now depends on it, triggering instantiation.
  • Fixes file system provider not being found errors (ENOPRO) when MCPs or extensions
    try to access chat response resources.

Refs #299504

(Commit message generated by Copilot)

- Moves the registerProvider call from ChatResponseResourceFileSystemProvider constructor
  to a new ChatResponseResourceWorkbenchContribution class that gets instantiated by
  the workbench. This ensures the vscode-chat-response-resource:// file system provider
  is registered even though the service has no other dependencies that would trigger
  eager instantiation.
- Changes the singleton registration from Eager to Delayed since the workbench
  contribution now depends on it, triggering instantiation.
- Fixes file system provider not being found errors (ENOPRO) when MCPs or extensions
  try to access chat response resources.

Fixes #299504

(Commit message generated by Copilot)
Copilot AI review requested due to automatic review settings March 5, 2026 16:47
@connor4312 connor4312 enabled auto-merge (squash) March 5, 2026 16:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@connor4312 connor4312 merged commit 2dbd83b into main Mar 6, 2026
20 checks passed
@connor4312 connor4312 deleted the connor4312/299504 branch March 6, 2026 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants