Port chat input overflow fix to main#299901
Conversation
The part of #299863 that wasn't in main
There was a problem hiding this comment.
Pull request overview
This PR ports the CSS portion of PR #299863 (a release-branch cherry-pick) to main, fixing issue #299484. The fix prevents child content from visually covering the rounded border corners of the chat input container by adding overflow: hidden — but intentionally skips compact mode, where that property triggers a ResizeObserver ↔ layout feedback loop caused by toolbars sharing width with the editor.
Changes:
- Adds
overflow: hiddento.chat-input-containerscoped to non-compact mode only, with an explanatory block comment describing why compact mode is excluded.
| because overflow:hidden creates a BFC that causes a ResizeObserver ↔ layout | ||
| feedback loop when toolbars share width with the editor. */ | ||
| .interactive-session .interactive-input-part:not(.compact) .chat-input-container { | ||
| /* Prevent contents from covering border corner */ |
There was a problem hiding this comment.
The inline comment on line 827 (/* Prevent contents from covering border corner */) duplicates the information already stated in the block comment immediately above (lines 823–825), which provides a more complete explanation. The inline comment adds no new information and should be removed.
| /* Prevent contents from covering border corner */ |
The part of #299863 that wasn't in main